Da
Show enters and exits. Hide enters and exits.
| 00:48:40 | boyscout | Fix Thread.critical= allows all non-bool arguments - 4cc7cf9 - Jose Narvaez |
| 00:48:40 | boyscout | Remove tags for passing Thread.critical= specs, also removed duplicated Thread.critical= tags - 8cd6c66 - Jose Narvaez |
| 01:16:38 | boyscout | CI: rubinius: 8cd6c66 successful: 3502 files, 14747 examples, 42555 expectations, 0 failures, 0 errors |
| 01:42:46 | brixen | goyox86: I think that's a case where !!value makes sense |
| 01:43:26 | brixen | goyox86: also, we have a to_bool method |
| 01:44:20 | goyox86 | brixen: mmm, just let me know which one and i'll be fixin it :) |
| 01:44:31 | brixen | well, to_bool was created for these cases |
| 01:44:43 | brixen | see the comment in kernel/bootstrap/kernel.rb |
| 01:45:06 | goyox86 | brixen: 10-04 |
| 01:45:58 | brixen | honestly, I'm on the fence whether !!value or to_bool is better, but consistency is good |
| 01:47:06 | goyox86 | brixen: when you have decided just let me know :), anyway i'll do my own research :) |
| 01:47:36 | brixen | heh, I think the to_bool is appropriate |
| 01:55:09 | goyox86 | brixen: better? https://gist.github.com/d1fd80fb46f27576dace |
| 01:57:02 | brixen | looks good |
| 01:57:50 | goyox86 | brixen: k, CI-ing now |
| 02:02:55 | boyscout | Better fix for Thread.critical= allows all non-bool arguments, using to_bool, as brixen suggested - c2a6165 - Jose Narvaez |
| 02:03:33 | goyox86 | brixen: sorry by that bro :] |
| 02:15:13 | brixen | goyox86: no worries :) |