Show enters and exits. Hide enters and exits.
| 10:05:08 | rue | Ar#replace seems to be hanging. |
| 10:44:06 | boyscout | Fix Kernel#dup to work on an object with #send undefined. Closes #98. - 35a2ed0 - Dan Kubb |
| 10:44:06 | boyscout | configure outputs confirmation. - 6216872 - Eero Saynatkari |
| 10:44:21 | rue | WTF, where is that -arch getting inserted? |
| 10:44:36 | rue | I removed the Makefile and it still creeps up somewhere |
| 10:47:03 | boyscout | CI: 6216872 success. 3005 files, 11471 examples, 35614 expectations, 0 failures, 0 errors |
| 18:47:03 | dbussink | brixen: evan: one of you guys available? |
| 18:56:16 | iamstef | hey guys |
| 19:05:21 | dbussink | hi |
| 19:26:05 | dbussink | brixen: ping? |
| 19:26:37 | dbussink | people who tweet give themselves away ;) |
| 19:27:24 | boyscout | Raise ArgumentError of no arguments are given to send instead of segfaulting - b706a96 - Dirkjan Bussink |
| 19:27:24 | boyscout | Add spec to verify ArgumentError is thrown when send is not given any arguments - cb9edee - Dirkjan Bussink |
| 19:27:24 | boyscout | Use System::vm_backtrace properly - 39a1ae4 - Dirkjan Bussink |
| 19:30:37 | boyscout | CI: 39a1ae4 success. 3005 files, 11472 examples, 35615 expectations, 0 failures, 0 errors |
| 19:31:25 | brixen | dbussink: sup? I'm about to run errands... |
| 19:31:56 | dbussink | brixen: i was wondering if you could check some style changes i wanted to make in string.rb matches the preferred style |
| 19:32:08 | brixen | k |
| 19:32:22 | dbussink | brixen: https://gist.github.com/7f44f7d6ca4c6f104eae |
| 19:33:49 | brixen | no to the something == x && \n something |
| 19:33:51 | brixen | that's horrid |
| 19:33:55 | brixen | sorry :( |
| 19:34:27 | dbussink | that was the one i was doubting on most |
| 19:34:29 | brixen | removing 'return' in general is fine |
| 19:34:39 | brixen | unless it's clearer with return |
| 19:34:44 | brixen | and sometimes it is |
| 19:35:04 | dbussink | well, i usually prefer return to short circuit stuff |
| 19:35:44 | brixen | in general, I prefer and to && |
| 19:35:55 | brixen | unless it's an assignment and you need the higher precedence |
| 19:35:55 | dbussink | brixen: how do you feel about those last few changes in there? or do you prefer the return there? |
| 19:36:16 | brixen | I think the return forms are clearer personally |
| 19:36:20 | brixen | in those last cases |
| 19:36:28 | brixen | there's less to parse |
| 19:36:42 | brixen | I don't really have to think about the conjuction |
| 19:36:54 | brixen | anyway, you should pass this by evan probably |
| 19:37:00 | brixen | it's a good set of cases |
| 19:37:02 | dbussink | well, this is also personal i guess |
| 19:37:10 | dbussink | because i sometimes feel the other way around :) |
| 19:37:23 | brixen | the conditional has too much stuff |
| 19:37:29 | brixen | if x == 5 or y = 3 |
| 19:37:31 | brixen | fine |
| 19:37:47 | brixen | this has a receiver send with multiple arguments |
| 19:37:50 | brixen | some of which are modified |
| 19:37:54 | brixen | ie -size, size |
| 19:37:57 | brixen | and conditionals |
| 19:38:09 | brixen | er relations and a conjuction |
| 19:38:34 | brixen | that's not simpler if you're following what we know of cognitive science and the rough rule of 7 |
| 19:38:46 | brixen | all this isn't just personal preference |
| 19:40:07 | dbussink | well, some parts are, some aren't |
| 19:40:28 | brixen | indeed |
| 19:40:59 | brixen | one common mistake ppl make is assuming something make sense b/c they just spend 15 minutes figuring it out |
| 19:41:13 | brixen | the test has to be, does it make sense when I just read it |
| 19:41:18 | dbussink | hehe, that's true yeah |
| 19:41:18 | brixen | the first time |
| 19:41:32 | dbussink | but that also has your personal background as a big factor |
| 19:41:59 | dbussink | do you mind using the fact that an assignments returns the value too? |
| 19:42:11 | dbussink | i see things like a = 1 |
| 19:42:13 | dbussink | return a |
| 19:42:26 | dbussink | sometimes, to me they seem superflous, but maybe that's me then |
| 20:01:37 | rue | && and || have a more obvious precedence |
| 22:57:07 | stepheneb | I'l looking into what's not working when building with a custom --prefix ... |
| 22:58:57 | stepheneb | running ./configure with a custom --prefix and rake:build:normal works but lib/ and runtime/ are not copied to the custom build dir |
| 22:59:45 | stepheneb | so running bin/rbx fails |
| 23:00:24 | stepheneb | because rbx was configured to find the runtime directory at: /Users/stephen/dev/ruby/builds/rubinius/runtime |